ubuntu-webapps-bugs team mailing list archive

[Olivier Tilloy <olivier.tilloy@xxxxxxxxxxxxx>]

I confirm that
https://chromium.googlesource.com/chromium/src/+/f62ca6f9d33e93733fccb3f3815d9554429dbb38
introduced the regression: serialized navigation entries are pickled one
after the other, and the size of the resulting data is not stored
anywhere. As a result, the new implementation of
SerializedNavigationEntry::ReadFromPickle() starts reading from the
beginning of the next entry looking for extended info.

It is unfortunate that navigation entries are serialized this way. To
prevent this from happening again in the future when additional data is
added to serialized navigation entries, we should pickle them
separately, and for each entry store the size followed by the raw data.

** Changed in: webbrowser-app (Ubuntu)
       Status: New => Invalid

** Changed in: oxide
       Status: New => Confirmed

** Changed in: oxide
     Assignee: (unassigned) => Olivier Tilloy (osomon)

** Changed in: oxide
    Milestone: None => branch-1.20

** Also affects: oxide/1.19
   Importance: Undecided
       Status: New

** Changed in: oxide
   Importance: Undecided => High

** Changed in: oxide/1.19
   Importance: Undecided => Critical

** Changed in: oxide/1.19
     Assignee: (unassigned) => Olivier Tilloy (osomon)

** Changed in: oxide/1.19
       Status: New => Confirmed

-- 
You received this bug notification because you are a member of Ubuntu
WebApps bug tracking, which is subscribed to Oxide.
https://bugs.launchpad.net/bugs/1649861

Title:
  When upgrading to oxide 1.19, tabs from saved session are not restored

Status in Oxide:
  Confirmed
Status in Oxide 1.19 series:
  Confirmed
Status in webbrowser-app package in Ubuntu:
  Invalid

Bug description:
  When upgrading to oxide 1.19, tabs from a session saved with oxide
  1.18 are not restored. I’m seeing the following in the browser’s log:

    Failed to read initial state: invalid data

  It appears sessions::SerializedNavigationEntry::ReadFromPickle()
  fails, most likely because the format of the serialized entries was
  changed in chromium 55. Specifically, this commit seems like a good
  suspect:
  https://chromium.googlesource.com/chromium/src/+/f62ca6f9d33e93733fccb3f3815d9554429dbb38.

To manage notifications about this bug go to:
https://bugs.launchpad.net/oxide/+bug/1649861/+subscriptions