← Back to team overview

ubuntu-x-swat team mailing list archive

[Bug 720389] Re: The touchpad works very bad

 

In 129-clickpad-threshold.patch I notice your patch reverses a chunk
that the opensuse patch was removing.  This bit of code:

@@ -524,6 +512,9 @@
 
     pars->area_top_edge = set_percent_option(opts, "AreaTopEdge", height, priv->miny);                            
     pars->area_bottom_edge = set_percent_option(opts, "AreaBottomEdge", height, priv->miny);                      
+    /* in clickpad mode, we don't want to sense the button area as default */                                     
+    if (pars->area_bottom_edge == 0 && priv->is_clickpad)                                                         
+       pars->area_bottom_edge = b;                                                                                
     pars->area_left_edge = set_percent_option(opts, "AreaLeftEdge", width, priv->minx);                           
     pars->area_right_edge = set_percent_option(opts, "AreaRightEdge", width, priv->minx);                         
 
I'm wondering if this was just an oversight, or if it's actually something you found was necessary to add?  Can you explain why this chunk is being added in your patch?  I'm going to omit it for now.

-- 
You received this bug notification because you are a member of Ubuntu-X,
which is subscribed to xserver-xorg-input-synaptics in Ubuntu.
https://bugs.launchpad.net/bugs/720389

Title:
  The touchpad works very bad