← Back to team overview

ubuntu-x-swat team mailing list archive

[Bug 877825] Re: Crash when accepting a grabbed touch from an indirect device

 

** Description changed:

- There is a null pointer dereference that occurs when accepting a grabbed
- touch from a touchpad.
+ SRU Justification:
+ ==================
+ [Impact]
+ There are no known users of touch grabs in the Oneiric archives. However, development of the new uTouch architecture depends on touch grabs. This bug needs to be fixed as an SRU so further development can take place on Oneiric.
+ 
+ [Development Fix]
+ This issue will not be fixed in precise because the multitouch code will be different there.
+ 
+ [Stable Fix]
+ See attached patch. Note that the 'if' statement clause that is just above the patch is "if (first)". The fix is pretty obvious.
+ 
+ [Test Case]
+ There is not an obvious test case because nothing in the archive tests this functionality. Adventurous testers can checkout the following branches:
+ 
+ lp:~chasedouglas/utouch-frame/v2
+ lp:~chasedouglas/utouch-grail/rework
+ 
+ Build them sequentially, then run "tools/grail-test-propagation <root
+ window ID>" from the utouch-grail branch. Perform any two touch gesture
+ from a multitouch trackpad (currently limited to Apple trackpads). The
+ server will crash immediately.
+ 
+ [Regression Potential]
+ Minimal. The fix is an obvious code path issue that can be trivially "proven". It also will not affect anyone on non-multitouch hardware.

** Patch added: "510_fix_touchpad_touch_event_removal.patch"
   https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/877825/+attachment/2559081/+files/510_fix_touchpad_touch_event_removal.patch

** Also affects: xorg-server (Ubuntu Oneiric)
   Importance: Undecided
       Status: New

** Changed in: xorg-server (Ubuntu)
       Status: New => Won't Fix

** Changed in: xorg-server (Ubuntu Oneiric)
     Assignee: (unassigned) => Chase Douglas (chasedouglas)

** Changed in: xorg-server (Ubuntu Oneiric)
   Importance: Undecided => Medium

** Changed in: xorg-server (Ubuntu Oneiric)
    Milestone: None => oneiric-updates

** Changed in: xorg-server (Ubuntu Oneiric)
       Status: New => In Progress

-- 
You received this bug notification because you are a member of Ubuntu-X,
which is subscribed to xorg-server in Ubuntu.
https://bugs.launchpad.net/bugs/877825

Title:
  Crash when accepting a grabbed touch from an indirect device

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/xorg-server/+bug/877825/+subscriptions


References