ubuntubudgie-dev team mailing list archive

[fossfreedom <1811522@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

The budgie-artwork package is an umbrella package for the look-and-feel
for Ubuntu Budgie.  Included with this source package is a binary
package called ubuntu-budgie-themes which has the precompiled GTK+ theme
for Ubuntu Budgie called Pocillo.

A number of issues have been raised since the 18.04 release. As part of
ongoing 18.04 & 18.10 support the Ubuntu Budgie Team proposes to wrap up
fixes as a SRU release for both 18.04 and 18.10. In this  SRU we have
wrapped up reported issues that have been classified as LOW by the UB
dev team. In addition the scope of the change has been assessed to limit
the potential of regression. This is to ensure this SRU requests is
strictly limited in scope with the risk(s) being easily determinable.

Pocillo consists of 6 variants and whilst the theme changes themselves
are small, the nature of GTK+ theming means the diff are basically
repeated 6x.

All the issues noted below have already been uploaded to 19.04.  The CSS
elements of the 19.04 theme have been copied back to the budgie-artwork
packages for 18.04/18.10 - i.e. backported directly rather than
regenerated.  This eliminates the risk of recompilation effects.

[Impact]

The following Pocillo issues have been resolved for 18.04:

    Raven Styling
    Vertical dock highlighting
    GtkColorChooser border truncation
    GEdit search styling
    Eog zoom truncation
    Ensure Titlebar button are always circular
    Nemo not themed

Most of these issues have been wrapped up in the 18.10 release.  The
remaining issues from the above that apply to 18.10 are:

    Raven Styling
    GtkColorChooser border truncation
    Nemo not themed


[Test Case - 18.04]

1. Open GEdit and examine the search (CTRL+F) - note the styling of the search box and the buttons are truncated.
2. Using Budgie-Settings add a left dock + icon-tasklist.  Open a few applications. Note it is not possible to see which are unopened applications compared to opened applications since there is no highlight mark to show opened windows.
3. Repeat 1 & 2 for each of the remaining Pocillo variants.
4. Install the package ubuntu-budgie-themes from Proposed, logout and login
5. Repeat 1 - 3 and note that the issues have been resolved

[Test Case - 18.10]

1. Open Raven and examine the Apps/Devices buttons - note in Pocillo those buttons are invisible.  You can see them appear if you switch to the inbuilt theme using budgie-desktop-settings.
2. Install the package ubuntu-budgie-themes from Proposed, logout and login
3. Repeat 1 for each of the Pocillo variants.  The apps/devices buttons are visible and styled.
 
[Regression Potential]

 * The worst case scenario is that the GTK+ theme changes affect other
aspects of the Pocillo theme.  This is thought very unlikely due to the
CSS changes are mostly named classes that are unique to each of the
areas of Budgie and are not repeated elsewhere.

[Other Info]

 None

** Affects: budgie-artwork (Ubuntu)
     Importance: Medium
     Assignee: fossfreedom (fossfreedom)
         Status: New

** Affects: budgie-artwork (Ubuntu Bionic)
     Importance: Undecided
         Status: New

** Affects: budgie-artwork (Ubuntu Cosmic)
     Importance: Undecided
         Status: New


** Tags: bionic cosmic

** Also affects: budgie-artwork (Ubuntu Cosmic)
   Importance: Undecided
       Status: New

** Also affects: budgie-artwork (Ubuntu Bionic)
   Importance: Undecided
       Status: New

-- 
You received this bug notification because you are a member of Ubuntu
Budgie Developers, which is subscribed to budgie-artwork in Ubuntu.
https://bugs.launchpad.net/bugs/1811522

Title:
  [SRU] Resolve Pocillo theming issues for Ubuntu Budgie

Status in budgie-artwork package in Ubuntu:
  New
Status in budgie-artwork source package in Bionic:
  New
Status in budgie-artwork source package in Cosmic:
  New

Bug description:
  The budgie-artwork package is an umbrella package for the look-and-
  feel for Ubuntu Budgie.  Included with this source package is a binary
  package called ubuntu-budgie-themes which has the precompiled GTK+
  theme for Ubuntu Budgie called Pocillo.

  A number of issues have been raised since the 18.04 release. As part
  of ongoing 18.04 & 18.10 support the Ubuntu Budgie Team proposes to
  wrap up fixes as a SRU release for both 18.04 and 18.10. In this  SRU
  we have wrapped up reported issues that have been classified as LOW by
  the UB dev team. In addition the scope of the change has been assessed
  to limit the potential of regression. This is to ensure this SRU
  requests is strictly limited in scope with the risk(s) being easily
  determinable.

  Pocillo consists of 6 variants and whilst the theme changes themselves
  are small, the nature of GTK+ theming means the diff are basically
  repeated 6x.

  All the issues noted below have already been uploaded to 19.04.  The
  CSS elements of the 19.04 theme have been copied back to the budgie-
  artwork packages for 18.04/18.10 - i.e. backported directly rather
  than regenerated.  This eliminates the risk of recompilation effects.

  [Impact]

  The following Pocillo issues have been resolved for 18.04:

      Raven Styling
      Vertical dock highlighting
      GtkColorChooser border truncation
      GEdit search styling
      Eog zoom truncation
      Ensure Titlebar button are always circular
      Nemo not themed

  Most of these issues have been wrapped up in the 18.10 release.  The
  remaining issues from the above that apply to 18.10 are:

      Raven Styling
      GtkColorChooser border truncation
      Nemo not themed

  
  [Test Case - 18.04]

  1. Open GEdit and examine the search (CTRL+F) - note the styling of the search box and the buttons are truncated.
  2. Using Budgie-Settings add a left dock + icon-tasklist.  Open a few applications. Note it is not possible to see which are unopened applications compared to opened applications since there is no highlight mark to show opened windows.
  3. Repeat 1 & 2 for each of the remaining Pocillo variants.
  4. Install the package ubuntu-budgie-themes from Proposed, logout and login
  5. Repeat 1 - 3 and note that the issues have been resolved

  [Test Case - 18.10]

  1. Open Raven and examine the Apps/Devices buttons - note in Pocillo those buttons are invisible.  You can see them appear if you switch to the inbuilt theme using budgie-desktop-settings.
  2. Install the package ubuntu-budgie-themes from Proposed, logout and login
  3. Repeat 1 for each of the Pocillo variants.  The apps/devices buttons are visible and styled.
   
  [Regression Potential]

   * The worst case scenario is that the GTK+ theme changes affect other
  aspects of the Pocillo theme.  This is thought very unlikely due to
  the CSS changes are mostly named classes that are unique to each of
  the areas of Budgie and are not repeated elsewhere.

  [Other Info]

   None

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/budgie-artwork/+bug/1811522/+subscriptions