ubuntukylin-members team mailing list archive

[Barry Warsaw <1203958@xxxxxxxxxxxxxxxxxx>]

I see a number of problems with this packaging.  Since this is the
initial upload, I think it's best to fix this before it gets uploaded.

The d/changelog entry should refer to this bug, e.g.

=== modified file 'debian/changelog'
--- debian/changelog	2013-07-23 04:53:42 +0000
+++ debian/changelog	2013-07-23 18:59:51 +0000
@@ -1,6 +1,6 @@
 unity-china-photo-scope (1.1-0ubuntu1) saucy; urgency=low
 
-  * Initial release.
+  * Initial release.  (LP: #1203958)
 
  -- Ubuntu daily release <jingshi@xxxxxxxxxxxxxxx>  Wed, 05 Jun 2013 06:08:36 +0000


I'm not sure why you should need python-distutils-extra since this is a Python 3 package, but it does seem like you do, otherwise pyversions fails.  It would be useful to track this down, but not critical.

The source package stanza in d/control should include

X-Python3-Version: >= 3.2

It would be nice (but not critical) if lines were wrapped to 79
characters and extraneous trailing whitespace were removed.

The d/watch file has an incorrect regexp.  Please check that `uscan
--report --force` can find your tarball.  Here's what I did:

=== modified file 'debian/watch'
--- debian/watch	2013-07-18 06:31:02 +0000
+++ debian/watch	2013-07-23 20:05:11 +0000
@@ -1,2 +1,2 @@
-version=1
-http://launchpad.net/unity-china-photo-scope/+download .*/unity-china-photo-scope-([0-9.]+)\.tar\.gz
+version=3
+https://launchpad.net/unity-china-photo-scope/+download https://launchpad.net/unity-china-photo-scope/.*/unity-china-photo-scope-(.*)\.tar\.gz

You should include a debian/source/format file containing:

3.0 (quilt)

Please do a local build with either sbuild or pbuilder and take a look
at the lintian warnings both for the source package and binary packages:

Now running lintian...
W: unity-china-photo-scope source: comma-separated-files-in-dep5-copyright paragraph at line 22
W: unity-china-photo-scope source: out-of-date-standards-version 3.9.3 (current is 3.9.4)

% lintian *.deb
W: unity-china-photo-scope: package-relation-with-self breaks: unity-china-photo-scope
W: unity-china-photo-scope: desktop-entry-lacks-main-category usr/share/applications/unity-china-photo-scope.desktop

Your source tarball also has some problems.  It includes a pyc file that
is properly ignored.  (All pyc files get created at install time):

dpkg-source: warning: ignoring deletion of file build_i18n_ext.pyc

The source branch has some other anomalies that should get cleaned up:

 * Why is there a debhelper.log, *.debhelper, and *.substvars files in debian/?  
 * Why is the debian/unity-china-photo-scope directory there?
 * Since this is not a native package, nor is this a source branch, you probably don't want to include the upstream files in the branch.  You should only need the debian directory, since the upstream tarball will be downloaded from Launchpad.

If you can fix these problems, myself or another patch pilot will gladly
sponsor you.

** Tags added: patch-needswork

-- 
You received this bug notification because you are a member of
UbuntuKylin Members, which is subscribed to UbuntuKylin.
https://bugs.launchpad.net/bugs/1203958

Title:
  [needs-packaging] unity-china-photo-scope

Status in UbuntuKylin:
  New
Status in Ubuntu:
  New

Bug description:
  "unity-china-photo-scope" shows Chinese photo results searched from
  Sogou service (a popular photo search engine in China) and other photo
  in photo lens of Dash. It will be installed in UbuntuKylin 13.10, a
  Chinese flavor of Ubuntu.

  URL: https://launchpad.net/unity-china-photo-scope
  License: GPL V3+
  Notes: Comes in stable versions (1.1).

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntukylin/+bug/1203958/+subscriptions