ubuntustudio-bugs team mailing list archive

[Paul-licameli <529337@xxxxxxxxxxxxxxxxxx>]

This commit:
https://github.com/audacity/audacity/commit/376fc0ebf294ca39b56f0ef4177a995f2de11f26

Does not fix every inefficiency, but I think I found and fixed the
grossest problem, at least as it runs on Windows.

Details:

Lyrics::mHighlightTextCtrl is there to implement a different mode in
which the Lyrics window displays multiple lines, but the code making the
radio button to enable this mode is commented out.  Yet, there is code
updating this invisible text control, and that seems to be eating most
of the time up:

  int nTextLen = mSyllables[i].textWithSpace.Length();
  if ((nTextLen > 0) && (mSyllables[i].textWithSpace.Right(1) == wxT("_")))
     mHighlightTextCtrl->AppendText(mSyllables[i].textWithSpace.Left(nTextLen - 1) + wxT("\n"));
    else
      mHighlightTextCtrl->AppendText(mSyllables[i].textWithSpace);

... and the many AppendText() calls (one for each label) each cause
processing of an event, at least in the Windows implementation of
wxTextCtrl.

Commenting out the above lines fixes most of the delay.

But rather than do that, which might be best for speed, I just rewrite
things to compose one big string and then call AppendText once, and
edits are then tolerably fast.  Maybe somebody wants to reenable
mHighlightTextCtrl some day?

-- 
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to audacity in Ubuntu.
Matching subscriptions: Ubuntu Studio Bugs
https://bugs.launchpad.net/bugs/529337

Title:
  Hangs for a long time when editing labels on large files

Status in Audacity:
  Unknown
Status in audacity package in Ubuntu:
  Triaged

Bug description:
  Binary package hint: audacity

  How to trigger this bug:

   1) Create a fairly long audio file (in this case 45 minutes)
   2) Create a label track with a bunch of long labels in it (i.e. transcriptions)
   3) Try to edit the text in one of the labels, preferably the first one

  Audacity will freeze for quite a long time.

  Actually label editing has a bunch of problems but this one is
  particularly bad...  It turns out that the code that's responsible is
  the "experimental lyrics window", which can be shown when you choose
  "Karaoke..." from the View menu.

  You can easily disable this "feature" by commending out the
  EXPERIMENTAL_LYRICS_WINDOW line in src/Experimental.h, which makes it
  possible to edit label texts.  But I'm sure some people out there
  actually use it...

  ProblemType: Bug
  Architecture: amd64
  Date: Sun Feb 28 00:57:02 2010
  DistroRelease: Ubuntu 9.10
  InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
  NonfreeKernelModules: nvidia
  Package: audacity 1.3.9-6
  ProcEnviron:
   LANG=en_US.UTF-8
   SHELL=/bin/bash
  ProcVersionSignature: Ubuntu 2.6.32-12.16-generic
  SourcePackage: audacity
  Uname: Linux 2.6.32-12-generic x86_64

To manage notifications about this bug go to:
https://bugs.launchpad.net/audacity/+bug/529337/+subscriptions