ubuntustudio-bugs team mailing list archive

[Steve Langasek <steve.langasek@xxxxxxxxxxxxx>]

-    self.usb_plug_check.set_active(self.usb)
+    if self.usb == "True":
+        self.usb_plug_check.set_active(True)
+    elif self.usb == "False":
+        self.usb_plug_check.set_active(False)


I think this could be instead written as

    self.usb_plug_check.set_active(self.usb == "True")

to cast from a string to a boolean (unless you expect there to be other
possible values besides "True" and "False")

would you want to make this change in devel and reupload to the queue?

-- 
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to ubuntustudio-controls.
Matching subscriptions: UbuntuStudio Bugs, ubuntustudio-bugs
https://bugs.launchpad.net/bugs/1826413

Title:
  ALSA Jack Midi bridge off selection not surviving a reboot

Status in ubuntustudio-controls:
  Fix Committed
Status in ubuntustudio-controls package in Ubuntu:
  Fix Released
Status in ubuntustudio-controls source package in Disco:
  In Progress
Status in ubuntustudio-controls source package in Eoan:
  Fix Released

Bug description:
  [Impact]

   * As the status of the jack-midi and pulseaudio-jack bridges are not
  updated correctly from the config file, users have to open
  ubuntustudio-controls to set the required status every time they
  login/logout/reboot.

   * The bug is very annoying for users that need to adjust their jack
  settings to cater for different audio software and hardware.

   * The statuses read from the config file are a string. When
  converting from string to boolean to set the check button status in
  the gui, python will always evaluate the boolean as "True" for any
  string except "None". Now the strings are parsed with some if/elif
  statments to set the correct boolean status for the check button.

  [Test Case]

   * Run ubuntustudio-controls

   * The first time ubuntustudio-controls is run, the 4 tick boxes in
  the gui (e.g. "Auto Start Jack at Session Start") should be set to the
  recommended defaults for Ubuntu Studio. Change the tick boxes to
  something else (e.g. all off).

   * Click Apply Audio Settings (saves the settings to a configuration
  file).

   * Close Ubuntu Studio Controls.

   * Restart Ubuntu Studio Controls. The previous settings should be
  remembered. Previously to the fix, the recommended defaults were set
  (ignoring the settings saved in the configuration file).

  [Regression Potential]

   * The changes are limited to the ubuntustudio-controls app, and this
  package is only ever installed for Ubuntu Studio users, or users that
  want to add the Ubuntu Studio settings to their favourite flavour. The
  only reverse dependency is the Ubuntu Studio meta-package.

   * The changes have been tested in my ppa
  (https://launchpad.net/~rosco2/+archive/ubuntu/testing) for Disco with
  no apparent regressions.

  [Other Info]

   * The same changes (uploaded to Eoan) have been backported in our
  Ubuntu Studio Backports PPA (https://launchpad.net/~ubuntustudio-
  ppa/+archive/ubuntu/backports) and is therefore already in the hands
  of many users.

  [Original Description]

  Several users on the Ubuntu Studio list have reported that they only
  want the ALSA Jack Midi bridge to be active sometimes.

  When switched off in ubuntustudio-controls it always restarts with it
  enabled again which is very inconvenient.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntustudio-controls/+bug/1826413/+subscriptions