ubuntustudio-bugs team mailing list archive

[Erich Eickmeyer <1849168@xxxxxxxxxxxxxxxxxx>]

Everything on this fix checks good. Actual sounds are being produced by
synthesizer plugins per my tests.

** Tags removed: verification-needed verification-needed-eoan
** Tags added: verification-done verification-done-eoan

-- 
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to carla in Ubuntu.
https://bugs.launchpad.net/bugs/1849168

Title:
  [SRU] Missing build dep libsndfile1-dev discovered

Status in carla package in Ubuntu:
  Fix Released
Status in carla source package in Eoan:
  Fix Committed

Bug description:
  [Impact]

   * Users have reported the inability to use soundfonts with Carla
  hosted allowing them to make sound which they weren't before.

   * Backporting this to the stable release would fix the problem.

   * The upload simply adds libsndfile1-dev as a build dependency, also
  includes an upstream patch from the author to fix incompatibilities
  with lsp-plugins.

  [Test Case]

   * Add any soundfont-utilizing synthesizer plugin to Carla, patch
  audio out to system out, attempt to play notes either using a MIDI
  keyboard or using the canvas keyboard in Carla. Carla gives the
  following error: ad_open(): fatal: no decoder backend available

   * Using the same procedures after the libsndfile1-dev build
  dependency is added should result in actual notes being produced.

  [Regression Potential]

   * Adding libsndfile1-dev as a build dependency allows synthesizer
  plugins to actually make sound, which they weren't before, but instead
  were causing the aforementioned error. This is primarily to allow said
  synthesizer to use sfz sound fonts. I see no regression potential
  here.

   * Adding the patch from the upstream developer (in debian/patches)
  fixes a compatibility issue with lsp-plugins in which the plugins were
  not behaving correctly in some cases. This has been tested to work
  upstream, and is included in the beta version of Carla 2.1. No
  regression here as it fixes an existing bug upstream.

   * Had to fix the debian/rules file to allow the wine bridges to build
  against the version of wine included in the archives due to a bug in
  said wine package. Mostly a workaround, but allows build to take
  place. If there is a regression here, I do not see it in my testing.
  (built correctly in ppa:ubuntustudio-dev/autobuild)

  [Other Information]

   * Upload includes a patch from upstream developer to fix
  compatibility issues with lsp-plugins, and debian/rules has been
  modified to deal with FTBFS bug introduced by wine-development
  included in eoan.

   * I have PPU rights on this package, so patch is not included in this
  bug report as no sponsorship is needed. Just looking for a "green
  light".

   * As of this writing, focal is in freeze, but the fix has been
  uploaded there as well and is in-queue.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/carla/+bug/1849168/+subscriptions