ubuntustudio-bugs team mailing list archive

[Jesper Lloyd <1878578@xxxxxxxxxxxxxxxxxx>]

Disclaimer: I'm the current MyPaint main developer/maintainer, but I
don't do the Debian packaging, nor am I in any capacity involved in
decisions about packages in Ubuntu.

Full details and consequences of this bug:

v2.0.0 was shipped with svg icons, most of which had been working fine
for 6+ years and had not been updated in that time. Some of these icons
make use of <use> elements (clones, in Inkscape terms), but not all
declared the xlink namespace, used to reference the items in the <use>
tags.

The backend that renders the icons is librsvg2.
Up until librsvg 2.47[2] the missing xlink namespace declarations had no impact, and the icons were rendered correctly regardless. With librsvg >=2.47 those same icons will not be rendered at all, and attempting to do so will throw an exception.

Now the real problem here is not that the icons are not rendering,
although that does hamper usability. The real problem is that one of the
problematic icons makes the "frame tool" (setting/configuring a canvas
outline) virtually unusable. The invalid icon for that tool causes an
exception that leads to an incomplete setup, causing further exceptions
when moving the cursor over the canvas, until you switch to another
mode.

The problem was first reported on the MyPaint irc channel 2020-03-12. It
was initially addressed that same evening, then finalized on 2020-03-17
(as the icon sheet and export process were reworked).

As previously indicated by Shane, the problem is in the mypaint-data
package[3], where the invalid icons are. All problematic icons can be
fixed by adding the attribute

xmlns:xlink="https://www.w3.org/1999/xlink";

to the <svg> tag.

To prevent the pseudo-crash when using the frametool, only this icon
needs fixing:

/usr/share/icons/hicolor/scalable/actions/mypaint-frame-symbolic.svg

To prevent the crash, and make all icons show up in the interface, these
icons need fixing:

/usr/share/icons/hicolor/24x24/actions/mypaint-frame-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-view-pan-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-object-move-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-view-mirror-horizontal-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-layers-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-view-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-view-fit-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-view-zoom-more-symbolic.svg
/usr/share/icons/hicolor/24x24/actions/mypaint-view-mirror-vertical-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/mypaint-frame-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/mypaint-object-move-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/mypaint-view-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/mypaint-view-fit-symbolic.svg
/usr/share/icons/hicolor/scalable/actions/mypaint-view-zoom-more-symbolic.svg

Creating a patch that updates only these icons is not difficult, though
it might be better to just update the package to the latest packaged
version (referenced by Shane).

For users who are affected by this (i.e, anyone who uses the frame
tool), particularly those who do not use the 1.x mode by default, I
would recommend using the latest official appimage release[4] for the
time being.

[1] https://wiki.ubuntu.com/StableReleaseUpdates
[2] https://gitlab.gnome.org/GNOME/librsvg/-/blob/3661cee1cd2781cd31ac096be7e157f2e661b36b/NEWS#L215-232
[3] https://packages.ubuntu.com/focal/mypaint-data
[4] https://github.com/mypaint/mypaint/releases/download/v2.0.1/MyPaint-v2.0.1.AppImage

-- 
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to mypaint in Ubuntu.
Matching subscriptions: Ubuntu Studio Bugs
https://bugs.launchpad.net/bugs/1878578

Title:
  Some menu icons are missing

Status in mypaint package in Ubuntu:
  Confirmed

Bug description:
  1. Ubuntu 20.04 LTS + Cinnamon

  2. Package: mypaint
  Architecture: amd64
  Version: 2.0.0-2

  4. Some icons on the menu panel are missing; this is reproducible on
  both Adwaita and MateFaenza icon sets.

  Also checked on the fresh-installed Ubuntu 20.04 in the virtual
  machine with default DE, the same issue appeared.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/mypaint/+bug/1878578/+subscriptions