ubuntustudio-bugs team mailing list archive

Thread
Date

[Bug 2047656] Re: [SRU] Players terminate after stopping and restarting

To: ubuntustudio-bugs@xxxxxxxxxxxxxxxxxxx
From: Erich Eickmeyer <2047656@xxxxxxxxxxxxxxxxxx>
Date: Thu, 11 Jan 2024 19:19:20 -0000
Reply-to: Bug 2047656 <2047656@xxxxxxxxxxxxxxxxxx>
Sender: noreply@xxxxxxxxxxxxx

Andreas, I fully support this. I can update the description with that as
it's a much simpler reproduction than a python script. :)

** Description changed:

[ Impact ]

Fluidsynth 2.3.3 has an issue where it will terminate upon start/stop of
playback of a midi song, causing issues for a multitude of players
including EasyABC. This will cause said player to be unable to playback
again and perhaps even crash. See
https://github.com/FluidSynth/fluidsynth/issues/1272, fix in
https://github.com/FluidSynth/fluidsynth/commit/377ab9db2f87bc407eeb940e0361edc77da77055.
This is the included patch with the upload of 2.3.3-2.1ubuntu-0.23.10.1

[ Test Case ]

- * See test in Comment 4 below
- (https://bugs.launchpad.net/ubuntu/+source/fluidsynth/+bug/2047656/comments/4)
+ * To reproduce the bug:
+
+ # download sample midi file from wikiepdia:
+
+ wget https://upload.wikimedia.org/wikipedia/commons/5/55/MIDI_sample.mid
+
+ # play it with fluidsynth
+
+ fluidsynth MIDI_sample.mid
+
+ # at this point, you will actually be at a prompt. Wait for the song to
+ play for a few seconds, then issue a stop command at that prompt:
+
+ player_stop
+
+ # And this is where the bug happens. Issue a continuation:
+
+ player_cont
+
+ And this is where things break:
+
+ > player_cont
+ > fluidsynth: error: The maximum playback duration has been reached. Terminating player!
+
+ * With the fixed package, the audio resumes playback.

[ What could go wrong ]

This is actually a fix for a regression that was found in version 2.3.3
of fluidsynth and fixed for 2.3.4, which can be found in noble. I think
the only thing that can go wrong here is that this patch is not the
actual fix and we need to find more solutions within.

I have tested this in my PPA and it *seems* to fix it, but it would be
nice if the original reporter could verify once this lands in proposed.

[ Other information ]

Included below is the original report, in which case the reporter
deduces that the problem is the binary being spat-out is the 2.3.2
version from the 2.3.3 sources. This is not the case, as it appears to
be confusion due to the -2.1 Debian revision number. I assure, this is
definitely the 2.3.3, and the bug, per the github link in the Impact
section, is pertinent to this version.

---

The latest package of fluidsynth should include the sources from version
2.3.3 but the binary includes only version 2.3.2

This version has a bug (see
https://github.com/FluidSynth/fluidsynth/issues/1272), which leads to
problems in EasyABC.

Please include the latest version 2.3.3 from upstream in the ubuntu
package.

Description: Ubuntu 23.10
Release: 23.10
Codename: mantic

$ apt-cache policy libfluidsynth3
libfluidsynth3:
Installiert: 2.3.3-2.1
Installationskandidat: 2.3.3-2.1
Versionstabelle:
*** 2.3.3-2.1 500
500 http://de.archive.ubuntu.com/ubuntu mantic/universe amd64 Packages
100 /var/lib/dpkg/status

--
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to fluidsynth in Ubuntu.
Matching subscriptions: Ubuntu Studio Bugs
https://bugs.launchpad.net/bugs/2047656

Title:
[SRU] Players terminate after stopping and restarting

Status in fluidsynth package in Ubuntu:
Fix Released
Status in fluidsynth source package in Mantic:
In Progress
Status in fluidsynth source package in Noble:
Fix Released

Bug description:
[ Impact ]

Fluidsynth 2.3.3 has an issue where it will terminate upon start/stop
of playback of a midi song, causing issues for a multitude of players
including EasyABC. This will cause said player to be unable to
playback again and perhaps even crash. See
https://github.com/FluidSynth/fluidsynth/issues/1272, fix in
https://github.com/FluidSynth/fluidsynth/commit/377ab9db2f87bc407eeb940e0361edc77da77055.
This is the included patch with the upload of
2.3.3-2.1ubuntu-0.23.10.1

[ Test Case ]

* To reproduce the bug:

# download sample midi file from wikiepdia:

wget
https://upload.wikimedia.org/wikipedia/commons/5/55/MIDI_sample.mid

# play it with fluidsynth

fluidsynth MIDI_sample.mid

# at this point, you will actually be at a prompt. Wait for the song
to play for a few seconds, then issue a stop command at that prompt:

player_stop

# And this is where the bug happens. Issue a continuation:

player_cont

And this is where things break:

> player_cont
> fluidsynth: error: The maximum playback duration has been reached. Terminating player!

* With the fixed package, the audio resumes playback.

[ What could go wrong ]

This is actually a fix for a regression that was found in version
2.3.3 of fluidsynth and fixed for 2.3.4, which can be found in noble.
I think the only thing that can go wrong here is that this patch is
not the actual fix and we need to find more solutions within.

I have tested this in my PPA and it *seems* to fix it, but it would be
nice if the original reporter could verify once this lands in
proposed.

[ Other information ]

---

The latest package of fluidsynth should include the sources from
version 2.3.3 but the binary includes only version 2.3.2

This version has a bug (see
https://github.com/FluidSynth/fluidsynth/issues/1272), which leads to
problems in EasyABC.

Please include the latest version 2.3.3 from upstream in the ubuntu
package.

Description: Ubuntu 23.10
Release: 23.10
Codename: mantic

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/fluidsynth/+bug/2047656/+subscriptions

References

[Bug 2047656] [NEW] libfluidsynth3 2.3.3-2.1 does not contain the version 2.3.3 but only version 2.3.2
From: Michael Mehl, 2023-12-28