ubuntustudio-bugs team mailing list archive

[Erich Eickmeyer <2077979@xxxxxxxxxxxxxxxxxx>]

** Description changed:

+ [ Impact ]
+ 
+ Audacity 3.6.1 included a bug which caused the waveform to disappear
+ when users zoom in and zoom out in the user interface. This is not only
+ inconvenient but also breaks the entire user interface because it makes
+ it impossible to work on anything as the entire user interface depends
+ on the waveform.
+ 
+ [ Test Case ]
+ 
+ * Install Audacity
+ 
+ * Open a sound file (any will do)
+ 
+ * Zoom in.
+  - Eventually waveform disappears If it does not, keep zooming.
+ 
+ Expected result: Waveform does not disappear
+ Actual result: Waveform disappears if zoomed in enough.
+ 
+ [ What problems could occur ]
+ 
+ This is a simple, one-line patch that is the basis for the same fix in
+ 3.6.2 that fixes the issue upstream:
+ 
+ +-   const int64_t cacheRight      = right / CacheElementWidth + 1;
+ ++   const int64_t cacheRight      = (right + CacheElementWidth - 1) / CacheElementWidth;
+ 
+ As this is a relatively simple patch, I don't foresee any problem,
+ however, there is obviously the risk that any patch can cause problems.
+ There's also the risk that this doesn't actually fix the problem and
+ needs further refinements later, but rather than do a microrelease here,
+ I'd rather start with this and see where it leads.
+ 
+ [ Other Information ]
+ 
+ Original bug report:
+ 
  As reported in https://github.com/audacity/audacity/issues/7108 by
  someone else, but fully reproducible with the oracular build of 3.6.1,
  the interface waveform render goes blank after a bit of zooming.
  
  This is an upstream bug fixed in
  https://github.com/audacity/audacity/pull/6955 , merged in the upcoming
  3.6.2 release.
  
  I've tested building oracular's 3.6.1 adding just commit bf7b2dd (i.e.
  https://github.com/audacity/audacity/commit/bf7b2dd95756f6077790ff8d4eb3306833203fa4.patch
  ) and can confirm it fully fixes this bug.
  
  The only reliable workaround I've found is to force the Audacity
  interface to fully re-render by accessing the Edit -> Preferences
  dialog, not changing anything, and closing it via the Ok button (as
  opposed to the Cancel button.) That of course doesn't prevent the
  problem from manifesting again after a few zoom operations, but it's
  better than nothing. Quite annoying though.
  
  Not aware of the release plans for oracular, but if there are no plans
  to ship 3.6.2, then that patch should probably be added in, since this
  bug is disruptive.

** Changed in: audacity (Ubuntu)
       Status: Triaged => In Progress

** Also affects: audacity (Ubuntu Oracular)
   Importance: Undecided
       Status: New

** Also affects: audacity (Ubuntu Plucky)
   Importance: Undecided
       Status: In Progress

** Changed in: audacity (Ubuntu Plucky)
       Status: In Progress => Fix Released

** Changed in: audacity (Ubuntu Oracular)
       Status: New => In Progress

** Description changed:

  [ Impact ]
  
  Audacity 3.6.1 included a bug which caused the waveform to disappear
  when users zoom in and zoom out in the user interface. This is not only
  inconvenient but also breaks the entire user interface because it makes
  it impossible to work on anything as the entire user interface depends
  on the waveform.
  
+ Note that this does *not* occur in later versions, therefore, this bug
+ does not apply to Plucky and therefore this is "Fix Released" in Plucky.
+ 
  [ Test Case ]
  
  * Install Audacity
  
  * Open a sound file (any will do)
  
  * Zoom in.
-  - Eventually waveform disappears If it does not, keep zooming.
+  - Eventually waveform disappears If it does not, keep zooming.
  
  Expected result: Waveform does not disappear
  Actual result: Waveform disappears if zoomed in enough.
  
  [ What problems could occur ]
  
  This is a simple, one-line patch that is the basis for the same fix in
  3.6.2 that fixes the issue upstream:
  
  +-   const int64_t cacheRight      = right / CacheElementWidth + 1;
  ++   const int64_t cacheRight      = (right + CacheElementWidth - 1) / CacheElementWidth;
  
  As this is a relatively simple patch, I don't foresee any problem,
  however, there is obviously the risk that any patch can cause problems.
  There's also the risk that this doesn't actually fix the problem and
  needs further refinements later, but rather than do a microrelease here,
  I'd rather start with this and see where it leads.
  
  [ Other Information ]
  
  Original bug report:
  
  As reported in https://github.com/audacity/audacity/issues/7108 by
  someone else, but fully reproducible with the oracular build of 3.6.1,
  the interface waveform render goes blank after a bit of zooming.
  
  This is an upstream bug fixed in
  https://github.com/audacity/audacity/pull/6955 , merged in the upcoming
  3.6.2 release.
  
  I've tested building oracular's 3.6.1 adding just commit bf7b2dd (i.e.
  https://github.com/audacity/audacity/commit/bf7b2dd95756f6077790ff8d4eb3306833203fa4.patch
  ) and can confirm it fully fixes this bug.
  
  The only reliable workaround I've found is to force the Audacity
  interface to fully re-render by accessing the Edit -> Preferences
  dialog, not changing anything, and closing it via the Ok button (as
  opposed to the Cancel button.) That of course doesn't prevent the
  problem from manifesting again after a few zoom operations, but it's
  better than nothing. Quite annoying though.
  
  Not aware of the release plans for oracular, but if there are no plans
  to ship 3.6.2, then that patch should probably be added in, since this
  bug is disruptive.

-- 
You received this bug notification because you are a member of Ubuntu
Studio Bugs, which is subscribed to audacity in Ubuntu.
Matching subscriptions: Ubuntu Studio Bugs
https://bugs.launchpad.net/bugs/2077979

Title:
  [SRU] Audacity 3.6.1: Waveform screen goes blank when zooming

Status in audacity package in Ubuntu:
  Fix Released
Status in audacity source package in Oracular:
  In Progress
Status in audacity source package in Plucky:
  Fix Released

Bug description:
  [ Impact ]

  Audacity 3.6.1 included a bug which caused the waveform to disappear
  when users zoom in and zoom out in the user interface. This is not
  only inconvenient but also breaks the entire user interface because it
  makes it impossible to work on anything as the entire user interface
  depends on the waveform.

  Note that this does *not* occur in later versions, therefore, this bug
  does not apply to Plucky and therefore this is "Fix Released" in
  Plucky.

  [ Test Case ]

  * Install Audacity

  * Open a sound file (any will do)

  * Zoom in.
   - Eventually waveform disappears If it does not, keep zooming.

  Expected result: Waveform does not disappear
  Actual result: Waveform disappears if zoomed in enough.

  [ What problems could occur ]

  This is a simple, one-line patch that is the basis for the same fix in
  3.6.2 that fixes the issue upstream:

  +-   const int64_t cacheRight      = right / CacheElementWidth + 1;
  ++   const int64_t cacheRight      = (right + CacheElementWidth - 1) / CacheElementWidth;

  As this is a relatively simple patch, I don't foresee any problem,
  however, there is obviously the risk that any patch can cause
  problems. There's also the risk that this doesn't actually fix the
  problem and needs further refinements later, but rather than do a
  microrelease here, I'd rather start with this and see where it leads.

  [ Other Information ]

  Original bug report:

  As reported in https://github.com/audacity/audacity/issues/7108 by
  someone else, but fully reproducible with the oracular build of 3.6.1,
  the interface waveform render goes blank after a bit of zooming.

  This is an upstream bug fixed in
  https://github.com/audacity/audacity/pull/6955 , merged in the
  upcoming 3.6.2 release.

  I've tested building oracular's 3.6.1 adding just commit bf7b2dd (i.e.
  https://github.com/audacity/audacity/commit/bf7b2dd95756f6077790ff8d4eb3306833203fa4.patch
  ) and can confirm it fully fixes this bug.

  The only reliable workaround I've found is to force the Audacity
  interface to fully re-render by accessing the Edit -> Preferences
  dialog, not changing anything, and closing it via the Ok button (as
  opposed to the Cancel button.) That of course doesn't prevent the
  problem from manifesting again after a few zoom operations, but it's
  better than nothing. Quite annoying though.

  Not aware of the release plans for oracular, but if there are no plans
  to ship 3.6.2, then that patch should probably be added in, since this
  bug is disruptive.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/audacity/+bug/2077979/+subscriptions