ufl team mailing list archive

[Martin Sandve Alnæs <martinal@xxxxxxxxx>]

On 12 May 2011 12:13, Anders Logg <logg@xxxxxxxxx> wrote:
> On Thu, May 12, 2011 at 10:52:50AM +0100, Garth N. Wells wrote:
>> Since there are no commit messages, can you tell us where the UFL/FFC
>> fixes to get DOLFIN working again are at?
>
> How do you mean? I don't yet know which fixes should be made to get
> DOLFIN working again or I would have fixed it already.
>
> I've fixed quite a few issues. FFC is green again and the test cases
> I've been using (JIT-compilation of Expressions and the DOLFIN
> function unit tests) run.
>
> The changes I've made are mainly to analysis.py (FFC) and
> preprocess.py (UFL) + tons of other files.
>
> The main outline of the change is:
>
> 1. preprocess tries to figure out the common cell
>
> 2. no elements are modified or mapped

Hmm...

Then the signature of the form will still be incomplete after preprocessing.
If there is no valid cell in the form, the form signature does not
identify whether it is in e.g. R^2 or R^3. Or am I missing something?

> 3. FFC keeps track of suitable values for cells and degrees when they
> are missing (as part of element_data computed in analysis.py)
>
> I'm about to leave my office and be offline for a few hours.
>
> --
> Anders

But the preprocess function does look nice now at least :)

Martin