← Back to team overview

ulc-devs team mailing list archive

Re: code merging request

 

Hi Patrick,

Am Samstag, den 10.12.2011, 22:58 +0100 schrieb Patrick Seemann:
> 
>         I just noticed two glitches in the current implementation:
>         Firstly,
>         whitespace was also listed in the "numbers" category. I fixed
>         this by
>         checking explicitly for "char.is_digit()". Secondly, it seems
>         that upper
>         and lower results are switched: lower-case chars appear in the
>         "upper"
>         category, and vice versa. I did not find out why, so I left it
>         for now.
>  
> I was aware of the number category displaying everything that wasn't a
> lower or upper case letter. I actually forgot to fix this, so thank
> you. I also remember that I had problems with the two categories
> (upper, lower) displaying wrong results, but I thought I had fixed it
> already. I overlooked the code again but I couldn't find anything. To
> verify, I downloaded the branch again (unity-lens-contacts) and after
> installing it seems to display the results correctly! Maybe try to
> apt-get remove --purge unity-lens-contacts and then rebranching and
> reinstalling the code...

You are right, there was still some old code running somewhere. After a
reboot, these issues were gone.

I’ll try to talk with the quickly devs about making a quickly template
from our current code. The template should override "quickly run" to
kill all old processes and run <lens-name>/__init__.py in order to start
a new lens daemon from the working directory. That will make testing a
bit easier I guess.

Regards
Frederik



References