unity-api-bugs team mailing list archive

[Matthew Paul Thomas <mpt@xxxxxxxxxxxxx>]

Sorry for my mistake. I had forgotten that the network menu includes
"Unlock SIM…" when the SIM is locked.
<https://wiki.ubuntu.com/Networking#phone-indicator>

But the normal case is for the unlock dialog to appear on startup.
<http://goo.gl/wtXjqx>

And as I mentioned, the dialog can also be invoked from System Settings
if you turn on the PIN.
<https://wiki.ubuntu.com/SecurityAndPrivacySettings#SIM_PIN>

I'm not an engineer, but it's a bit odd to me that two of those three
bits of code should have to supply an identical "Enter SIM PIN" string.
If you decided to improve the string later, you'd need to remember to
change it in both places. Seems to me that the string belongs in the
same place as the logic for the dialog -- the code that provides the
"Incorrect PIN. %d attempts remaining." string, that makes the button
insensitive when the PIN field contains an implausible number of digits,
and so on. System Settings would then override the title and button text
for its "Enter Previous PIN" dialog, but any other call-site would get
the default text.

-- 
You received this bug notification because you are a member of Unity API
bugs, which is subscribed to Network Menu.
https://bugs.launchpad.net/bugs/1267135

Title:
  network-indicator should provide the "Please enter SIM PIN" text

Status in Network Menu:
  Incomplete
Status in The Unity 8 shell:
  Triaged
Status in “ubuntu-system-settings” package in Ubuntu:
  New

Bug description:
  We are showing the "Please enter SIM PIN" text ourselves but according
  to Saviq it should come from the indicator and not be in our code.

To manage notifications about this bug go to:
https://bugs.launchpad.net/indicator-network/+bug/1267135/+subscriptions