unity-dev team mailing list archive

[Sam Spilsbury <smspillaz@xxxxxxxxx>]

On Thu, Jun 6, 2013 at 11:09 AM, Sam Spilsbury <smspillaz@xxxxxxxxx> wrote:
> I'll try and come up with test cases to cover as much of the plugin's
> functionality as possible. Given its current state, I expect some of
> these to be failing tests, so I won't add them to CI by default until
> we can make them all pass.
>
> The reason why I'd like to hold these two plugins is because that will
> at least give me some stability and something to work with whilst
> writing the testsuite.
>
> Is that okay with everyone? I apologize for the turbulence at the
> moment, its quite clear that we just need a better way of doing this.
>

Slight update:

1. I reverted the relevant revision that seemed to fix most things up
but had a race condition which could cause other problems.
2. Half way there with the tests -
https://code.launchpad.net/~compiz-team/compiz/compiz.fix_1188900/+merge/168386

It doesn't cover all of the discussed functionality, but it should at
least help us to get up and running with providing acceptance tests
and being able to have a better safety net for this code.

Where I've cut it and decided to just propose what I have is rather
arbitrary - I could keep going but the code review has grown to about
2000 lines now so it would be good to stop there and continue when
that's in place.

3. I plan to propose to unrevert the relevant revision once we can get
what it fixed + what it broke under test and get all the tests
passing.

Best,

Sam

> --
> Sam Spilsbury



--
Sam Spilsbury