uonedb-qt team mailing list archive

[Zoltan Balogh <zoltan.balogh@xxxxxxxxxxxxx>]

Review: Needs Fixing

Inline comments.

Diff comments:

> === modified file 'debian/control'
> --- debian/control	2014-01-22 13:14:22 +0000
> +++ debian/control	2016-03-01 13:02:26 +0000
> @@ -14,6 +14,7 @@
>                 qtdeclarative5-qtquick2-plugin,
>                 qtdeclarative5-test-plugin,
>                 qttools5-dev-tools,
> +               ubuntu-ui-toolkit-tools,

I would suggest to give a more generic name. Even ubuntu-toolkit-tools would be better, as the apicheck is expected to do other api's check too and not only ui api checks. Also a minimal version requirement  (>= 1.3.1872) would be nice as this tool comes with  1.3.1872 version

>                 ubuntu-ui-toolkit-doc,
>                 xvfb,
>                 libgl1-mesa-dri,
> 
> === modified file 'modules/U1db/CMakeLists.txt'
> --- modules/U1db/CMakeLists.txt	2013-08-08 10:11:39 +0000
> +++ modules/U1db/CMakeLists.txt	2016-03-01 13:02:26 +0000
> @@ -57,3 +57,14 @@
>  install(FILES ${CMAKE_CURRENT_BINARY_DIR}/plugins.qmltypes
>      DESTINATION ${QT_IMPORTS_DIR}/U1db
>      )
> +
> +add_custom_command(OUTPUT U1db.api
> +    COMMAND "ubuntu-ui-toolkit-apicheck" "U1db" "${CMAKE_CURRENT_SOURCE_DIR}/U1db.api" ">" "${CMAKE_CURRENT_BINARY_DIR}/U1db.api.new"

Is not the application called apicheck?

> +    WORKING_DIRECTORY "${CMAKE_SOURCE_DIR}"
> +    DEPENDS U1DBPlugin
> +    )
> +add_custom_target(api "ALL" DEPENDS U1db.api)
> +install(FILES ${CMAKE_CURRENT_SOURCE_DIR}/U1db.api
> +    DESTINATION ${CMAKE_INSTALL_PREFIX}/share/click/api/qml
> +    )
> +


-- 
https://code.launchpad.net/~uonedb-qt/u1db-qt/apiFile/+merge/287626
Your team U1DB Qt developers is requested to review the proposed merge of lp:~uonedb-qt/u1db-qt/apiFile into lp:u1db-qt.