usb-creator-hackers team mailing list archive

[tuos <tuos@xxxxxxxxxxxxx>]

tuos has proposed merging lp:~tuos/usb-creator/usb-creator.fix-610622 into lp:usb-creator.

Requested reviews:
  usb-creator hackers (usb-creator-hackers)
Related bugs:
  #610622 Crashes during startup with 'QString' object has no attribute 'rfind'
  https://bugs.launchpad.net/bugs/610622


Pass unicode-filepath to uic.loadUi instead of QString to fix #610622 in usb-creator kde-frontend. uic.loadUi() uses os.path.dirname() to find the directory of the filepath. os.path.dirname() in turn relies on str.rfind() which is not implemented in QString. This is from where the AttributeError originates.

The same kind of fix is used in printer-applet of kdeutils: http://bazaar.launchpad.net/~kubuntu-members/kdeutils/ubuntu/revision/85
-- 
https://code.launchpad.net/~tuos/usb-creator/usb-creator.fix-610622/+merge/31352
Your team usb-creator hackers is requested to review the proposed merge of lp:~tuos/usb-creator/usb-creator.fix-610622 into lp:usb-creator.

=== modified file 'debian/changelog'
--- debian/changelog	2010-07-22 13:39:00 +0000
+++ debian/changelog	2010-07-30 06:34:40 +0000
@@ -57,6 +57,9 @@
   * debian/copyright:
     + Added myself in the debian/* copyright
 
+  [ Tuomas Räsänen ]
+  * Pass unicode-filepaths instead of QString to uic.loadUi (LP: #610622)
+
  -- Roderick B. Greening <roderick.greening@xxxxxxxxx>  Thu, 22 Jul 2010 11:07:32 -0230
 
 usb-creator (0.2.22) lucid; urgency=low

=== modified file 'usbcreator/frontends/kde/frontend.py'
--- usbcreator/frontends/kde/frontend.py	2010-04-19 14:27:18 +0000
+++ usbcreator/frontends/kde/frontend.py	2010-07-30 06:34:40 +0000
@@ -119,7 +119,7 @@
         else:
             file =  KStandardDirs.locate("appdata", self.__mainWindow_ui)
             appdir = file.left(file.lastIndexOf("/"))
-        uic.loadUi(appdir + "/" + self.__mainWindow_ui, self.__mainWindow)
+        uic.loadUi(unicode(appdir + "/" + self.__mainWindow_ui), self.__mainWindow)
 
         #set default persist size
         self.__mainWindow.ui_persist_label.setText(format_mb_size(128))