usb-creator-hackers team mailing list archive

[Yu Ning <ning.yu@xxxxxxxxxxxxx>]

Yu Ning has proposed merging lp:~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269 into lp:usb-creator.

Requested reviews:
  usb-creator hackers (usb-creator-hackers)
Related bugs:
  Bug #1273925 in usb-creator (Ubuntu): "usb-creator-gtk fails to finish erasing a usb drive"
  https://bugs.launchpad.net/ubuntu/+source/usb-creator/+bug/1273925
  Bug #1289269 in usb-creator (Ubuntu): "Hangs while erasing disk"
  https://bugs.launchpad.net/ubuntu/+source/usb-creator/+bug/1289269

For more details, see:
https://code.launchpad.net/~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269/+merge/211465

* GTK: Handle the backend.format_ended_cb callback otherwise the erasing operation will never ended. (LP: #1289269) (LP: #1273925)
-- 
https://code.launchpad.net/~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269/+merge/211465
Your team usb-creator hackers is requested to review the proposed merge of lp:~yuningdodo/usb-creator/usb-creator.lp1273925+lp1289269 into lp:usb-creator.

=== modified file 'debian/changelog'
--- debian/changelog	2014-03-13 11:56:48 +0000
+++ debian/changelog	2014-03-18 09:37:48 +0000
@@ -1,3 +1,10 @@
+usb-creator (0.2.56) UNRELEASED; urgency=low
+
+  * GTK: Handle the backend.format_ended_cb callback otherwise the erasing
+         operation will never ended. (LP: #1289269) (LP: #1273925)
+
+ -- Yu Ning <ning.yu@xxxxxxxxxxxxx>  Tue, 18 Mar 2014 17:30:09 +0800
+
 usb-creator (0.2.55) trusty; urgency=medium
 
   * KDE: Don't crash when started with --iso. The hiding logic tried to access

=== modified file 'usbcreator/frontends/gtk/frontend.py'
--- usbcreator/frontends/gtk/frontend.py	2013-01-28 12:44:46 +0000
+++ usbcreator/frontends/gtk/frontend.py	2014-03-18 09:37:48 +0000
@@ -122,6 +122,7 @@
         self.backend.install_progress_pulse_stop_cb = self.progress_pulse_stop
         self.backend.retry_cb = self.retry
         self.backend.target_changed_cb = self.update_target
+        self.backend.format_ended_cb = self.format_ended
         self.backend.format_failed_cb = self.format_failed
 
         # Pulse state.
@@ -476,6 +477,10 @@
             msg = ''
         self.dest_status.set_text(msg)
 
+    def format_ended(self):
+        selection = self.dest_treeview.get_selection()
+        self.selection_changed_target(selection)
+
     def selection_changed_source(self, selection):
         model, iterator = selection.get_selected()
         if not iterator: