← Back to team overview

usb-creator-hackers team mailing list archive

Thread
Date

Re: [Merge] lp:~rohangarg/usb-creator/fix-for-1315866 into lp:usb-creator

To: Michał Zając <michal.zajac+launchpad@xxxxxxxxx>
From: Evan Dandrea <evan.dandrea@xxxxxxxxxxxxx>
Date: Tue, 06 May 2014 12:36:23 -0000
In-reply-to: <20140504220323.18994.7133.codereview@chaenomeles.canonical.com>
Reply-to: mp+218220@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Can you explain in a comment in the code exactly why this is
necessary? Please convince me this isn't a hack.

-- 
https://code.launchpad.net/~rohangarg/usb-creator/fix-for-1315866/+merge/218220
Your team usb-creator hackers is requested to review the proposed merge of lp:~rohangarg/usb-creator/fix-for-1315866 into lp:usb-creator.

References

Re: [Merge] lp:~rohangarg/usb-creator/fix-for-1315866 into lp:usb-creator
From: Michał Zając, 2014-05-04