← Back to team overview

usb-creator-hackers team mailing list archive

Re: [Merge] lp:~yuningdodo/usb-creator/usb-creator.lp978691-select-readded-source into lp:usb-creator

 

Thanks for the review. I have checked that patch before I compose my own one, and found it was already included in both ubuntu trusty and utopic.

Current status of usb-creator-gtk 0.2.56.2 (trusty-updates):
1. add a source for the first time, it will be selected, but the list will not be scrolled to it.
2. add a source for the second time, it won't be selected.

So my patch is actually based on your one:
1. add a source for the first time, it will be selected, the list will be automatically scrolled to it.
2. add a source for the second time, it will be selected, the list will be automatically scrolled to it.

SRU process requires a patch to be "clean", so I think it's better to commit your other patches separately instead of mixing them in this bug.
-- 
https://code.launchpad.net/~yuningdodo/usb-creator/usb-creator.lp978691-select-readded-source/+merge/238286
Your team usb-creator hackers is requested to review the proposed merge of lp:~yuningdodo/usb-creator/usb-creator.lp978691-select-readded-source into lp:usb-creator.


References