vm team mailing list archive

[Ulrich Mueller <ulm@xxxxxxxxxx>]

> Rob F added a definition for vm-find-coding-system in 8.0.x, revision
> 617.  This has now been merged into the 8.1.x branch.  Do we need to do
> more than this? -- Uday

This function appears only in the following combination:
   (coding-system-p (vm-find-coding-system x))

But "(coding-system-p nil)" returns t in GNU Emacs, so I guess the
above doesn't DTRT. (Basically, if x is not a valid coding system,
then vm-find-coding-system will return nil and coding-system-p will
return t.)

Maybe it would be cleaner if we defined a function vm-coding-system-p
for the combination. Something like the following (untested!):

   (defun vm-coding-system-p (name)
     (cond (vm-xemacs-mule-p
            (coding-system-p (find-coding-system name)))
           (vm-fsfemacs-mule-p
            (coding-system-p name))
           (t ; not sure about the fallback here
            )))

We shouldn't test for "(functionp 'find-coding-system)" because it
might give a false positive for an incompatible function of the same
name defined by the APEL library (with GNU Emacs).

Ulrich