vm team mailing list archive

[Uday Reddy <u.s.reddy@xxxxxxxxxxxxx>]

I notice that Rob has removed the better-filling stuff from vm-rfaddons.
So, this problem doesn't exist any more in 8.1.x. -- Uday


** Branch unlinked: lp:~reddyuday/viewmail/8.1

** Changed in: viewmail
       Status: New => Fix Released

-- 
vm-rfaddons-better-filling fails to use variable vm-paragraph-fill-column
https://bugs.launchpad.net/bugs/300842
You received this bug notification because you are a member of VM
development team, which is the registrant for VM (defunct).

Status in VM - Goto http://launchpad.net/vm for active development: Fix Released

Bug description:
vm-rfaddons-better-filling contains a bug, which I noticed as soon as I
upgraded to VM 8.  The problem appears in (at least) vm-8.0.11-581.
You can reproduce it by setting 
  (setq vm-fill-paragraphs-containing-long-lines 100)
  (setq vm-paragraph-fill-column 75)

The specification of function vm-fill-paragraphs-containing-long-lines is:
  * fills every paragraph that contains a line of length greater than
    variable vm-fill-paragraphs-containing-long-lines
  * fills those paragraphs to vm-paragraph-fill-column

vm-rfaddons-better-filling violates this specification, by using
variable vm-fill-paragraphs-containing-long-lines as the fill column (not
just to determine which paragraphs to fill).

Here is the fix that I am currently using.  :-)

  (ad-disable-advice 'vm-fill-paragraphs-containing-long-lines 'around 'vm-rfaddons-better-filling)
  (ad-activate 'vm-fill-paragraphs-containing-long-lines)

I propose that the vm-rfaddons-better-filling advice should be disabled by
default in rf-addons.el, at least until the advice is rewritten.