vm team mailing list archive

[Uday S Reddy <u.s.reddy@xxxxxxxxxxxxx>]

The following bug report was filed at launchpad, having to do with
multibyte setting during MIME decoding.  I have confirmed that the
problem does occur in Emacs23 with the current version of VM.  I
wonder if you ran into this problem as well?

I guessed that the user jcb+vm on Launchpad is you.  Am I right?  Do
you monitor the email on this account?  If so, I will just use it
instead of sending you more stuff at your work address.

Cheers,
Uday



------- start of forwarded message (RFC 934 encapsulation) -------
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Reply-To: Bug 495089 <495089@xxxxxxxxxxxxxxxxxx>
From: Richard Sharman <richard_sharman@xxxxxxxxx>
To: vm@xxxxxxxxxxxxxxxxxxx
Subject: [Vm] [Bug 495089] [NEW] "Display using External Viewer" produces
	corrupt	file under emacs 23
Date: Thu, 10 Dec 2009 15:31:57 -0000

Public bug reported:

The "Display using External Viewer" menu option isn't working under
Emacs-23.  The file produced is corrupted and typically is slightly
smaller than it should be.  This is with vm 7.19.   With emacs 22.1
this problem doesn't happen.

The "Save to File" does work, however.

I found that by removing the call to set-buffer-multibyte in
vm-mime-display-external-generic the problem went away.

% diff -c vm-mime.el.orig vm-mime.el
*** vm-mime.el.orig	Tue Dec  1 11:07:31 2009
- --- vm-mime.el	Thu Dec 10 10:12:31 2009
***************
*** 1967,1973 ****
  			    (vm-mime-transfer-decode-region layout
  							    (point-min)
  							    (point-max))
! 			    (set-buffer-multibyte t)
  			    (set-buffer target)
  			    (setq start (point))
  			    (insert-buffer-substring work-buffer)
- --- 1967,1973 ----
  			    (vm-mime-transfer-decode-region layout
  							    (point-min)
  							    (point-max))
! 			    ;; (set-buffer-multibyte t)
  			    (set-buffer target)
  			    (setq start (point))
  			    (insert-buffer-substring work-buffer)
% 


Examples of using the "Save to File"  
- -rw-------  1 sharman gx5000 3310 Dec 10 10:13 test.gif
- -rw-------  1 sharman gx5000 3424 Dec 10 10:13 test.jpeg
sharmanpc 19% 

whearas when using "Display using External Viewer" the temporary file
was a different size
- -rw-------  1 sharman gx5000 3302 Dec 10 10:12 test.gif
- -rw-------  1 sharman gx5000 3420 Dec 10 10:12 test.jpeg

** Affects: vm
     Importance: Undecided
         Status: New

- -- 
"Display using External Viewer" produces corrupt file under emacs 23
https://bugs.launchpad.net/bugs/495089
You received this bug notification because you are a member of VM
development team, which is the registrant for VM.

Status in VM (View Mail) for Emacs: New

Bug description:
The "Display using External Viewer" menu option isn't working under
Emacs-23.  The file produced is corrupted and typically is slightly
smaller than it should be.  This is with vm 7.19.   With emacs 22.1
this problem doesn't happen.

The "Save to File" does work, however.

I found that by removing the call to set-buffer-multibyte in
vm-mime-display-external-generic the problem went away.

% diff -c vm-mime.el.orig vm-mime.el
*** vm-mime.el.orig	Tue Dec  1 11:07:31 2009
- --- vm-mime.el	Thu Dec 10 10:12:31 2009
***************
*** 1967,1973 ****
  			    (vm-mime-transfer-decode-region layout
  							    (point-min)
  							    (point-max))
! 			    (set-buffer-multibyte t)
  			    (set-buffer target)
  			    (setq start (point))
  			    (insert-buffer-substring work-buffer)
- --- 1967,1973 ----
  			    (vm-mime-transfer-decode-region layout
  							    (point-min)
  							    (point-max))
! 			    ;; (set-buffer-multibyte t)
  			    (set-buffer target)
  			    (setq start (point))
  			    (insert-buffer-substring work-buffer)
% 


Examples of using the "Save to File"  
- -rw-------  1 sharman gx5000 3310 Dec 10 10:13 test.gif
- -rw-------  1 sharman gx5000 3424 Dec 10 10:13 test.jpeg
sharmanpc 19% 

whearas when using "Display using External Viewer" the temporary file
was a different size
- -rw-------  1 sharman gx5000 3302 Dec 10 10:12 test.gif
- -rw-------  1 sharman gx5000 3420 Dec 10 10:12 test.jpeg



_______________________________________________
Mailing list: https://launchpad.net/~vm
Post to     : vm@xxxxxxxxxxxxxxxxxxx
Unsubscribe : https://launchpad.net/~vm
More help   : https://help.launchpad.net/ListHelp

------- end -------