← Back to team overview

vm team mailing list archive

[Bug 343552] Re: Virtual folders invisible in menu in Emacs 23

 

The corresponding code is found in vm-menu.el, function vm-menu-install-
known-virtual-folders-menu (but I think that vm-menu-install-visited-
folders-menu suffers from the same problem).

According to documentation of easy-menu-define (whose API didn't change since 1994), a menu item in GNU Emacs normally is a vector and should look like one of the following:
   [ NAME CALLBACK ENABLE ]
   [ NAME CALLBACK [ KEYWORD ARG ] ... ]

In XEmacs the following alternative is accepted in addition to the ones listed above:
   [ NAME CALLBACK ACTIVE-P SUFFIX ]
which is equivalent to:
   [ NAME CALLBACK :active ACTIVE-P :suffix SUFFIX ]

Now vm-menu.el constructs entries of the form:
   [ "    "  (vm-menu-run-command ...) t folder-name ]
This is just the syntax that is allowed in XEmacs but not in GNU Emacs. (So I wonder how this could ever work in GNU Emacs 22?)

Therefore I believe that changing VM's menu entries to the following should fix the problem:
   [ "    "  (vm-menu-run-command ...) :suffix folder-name ]
(I've omitted the ":active t" because it seems to be redundant.)

I'll prepare a patch after I've tested it with GNU Emacs. Someone would
have to test it with XEmacs though.

-- 
Virtual folders invisible in menu in Emacs 23
https://bugs.launchpad.net/bugs/343552
You received this bug notification because you are a member of VM
development team, which is the registrant for VM (defunct).

Status in VM - Goto http://launchpad.net/vm for active development: Confirmed
Status in VM (View Mail) for Emacs: Confirmed

Bug description:
Virtual folders are listed in a menu in the VM frame when running on X. In  Emacs 23.0.91 (pretest) with VM 8.0.12 the menu entries are there and they do work, but they have no text on them. The user is left to find out by trial and error which blank line in the menu is which virtual folder.

This is on Fedora 10 running Emacs compiled to use the GTK toolkit and Xft. The menu does look right on Emacs 22 (GTK) on the same machine and VM version. The problem has been there in every pretest version of Emacs 23 and last several VM 8.0.x versions.

To reproduce: install Emacs 23 and the latest VM on Linux, configure some virtual folders and attempt to select them from the menu when running Emacs on X.