← Back to team overview

vm team mailing list archive

[PATCH] Call #'marker-position much less, drop #'vm-marker entirely

 

2018-09-23  Aidan Kehoe  <kehoea@xxxxxxxxxxxxx>

	Marker-related changes.
	1. Don't call #'marker-position when that is not necessary, this
	can be an O(N) operation under XEmacs that the C code can often
	avoid, and it is usually not necessary at the Lisp level.
	2. Drop #'vm-marker. Replace it in most use-cases with
	#'copy-marker, and the latter has been present since at least the
	late 1980s.
	Replace it in a minority of cases like (vm-marker (point)),
	(vm-marker (point-min)). with corresponding calls to
	(point-marker), (point-min-marker)
	* vm-folder.el (vm-retrieve-operable-messages):
	Change `defun' to `defun*' for this function, we use keywords and
	that fails without defun*
	* vcard.el (vcard-parse-region):
	* vcard.el (vcard-parse-region-value):
	* vm-folder.el (vm-munge-message-separators):
	* vm-folder.el (vm-build-message-list):
	* vm-folder.el (vm-read-index-file):
	* vm-folder.el (vm-retrieve-real-message-body):
	* vm-mime.el (vm-mime-layouts-equal):
	* vm-mime.el (vm-mime-verify-cached-layout):
	* vm-mime.el (vm-mime-charset-decode-region):
	* vm-mime.el (vm-mime-parse-entity):
	* vm-mime.el (vm-mime-parse-entity-safe):
	* vm-mime.el (vm-mime-convert-undisplayable-layout):
	* vm-mime.el (vm-mime-convert-undisplayable-charset):
	* vm-mime.el (vm-mime-fetch-message/external-body):
	* vm-rfaddons.el (vm-handle-return-receipt):
	* vm-sort.el (vm-sort-compare-physical-order):

-- 
‘As I sat looking up at the Guinness ad, I could never figure out /
How your man stayed up on the surfboard after forty pints of stout’
(C. Moore)

Attachment: vm-tip-incremental.diff
Description: Binary data