vmbuilder team mailing list archive

[Kieran Evans <keyz182@xxxxxxxxx>]

Kieran Evans has proposed merging lp:~keyz182/vmbuilder/bugfix-lp-688213 into lp:vmbuilder.

Requested reviews:
  VMBuilder (vmbuilder)
Related bugs:
  #688213 Filesystems output from running "vmbuilder xen ubuntu..." are named confusingly
  https://bugs.launchpad.net/bugs/688213

For more details, see:
https://code.launchpad.net/~keyz182/vmbuilder/bugfix-lp-688213/+merge/52157

A small change that allows you to specify a fourth option in a part file added through the --part switch which specifies a name of the output file for the partition


-- 
https://code.launchpad.net/~keyz182/vmbuilder/bugfix-lp-688213/+merge/52157
Your team VMBuilder is requested to review the proposed merge of lp:~keyz182/vmbuilder/bugfix-lp-688213 into lp:vmbuilder.

=== modified file 'VMBuilder/contrib/cli.py'
--- VMBuilder/contrib/cli.py	2011-01-04 21:09:31 +0000
+++ VMBuilder/contrib/cli.py	2011-03-04 02:51:10 +0000
@@ -348,8 +348,11 @@
                 try:
                     for line in file(self.options.part):
                         elements = line.strip().split(' ')
-                        tmpfile = util.tmp_filename(
-                            tmp_root=self.options.tmp_root)
+			if not elements[3]:
+				tmpfile = util.tmp_filename(tmp_root=self.options.tmp_root)
+			else:
+				tmpfile = elements[3]
+
                         if elements[0] == 'root':
                             hypervisor.add_filesystem(elements[1],
                                                        default_filesystem,