vmbuilder team mailing list archive

[Chad Smith <chad.smith@xxxxxxxxxxxxx>]

Daniel thanks for the solid review here.

1. Oops right. My description in the MP was bogus mentioning Bionic, changed to Artful, though the commit message will still only be the following:

Update Azure's nic hotplug script to use netplan if available instead of ENI

Also avoid appending unnecessary include directives in
/etc/network/interfaces on netplan-enabled systems.

2. We can't quite just write out a netplan match: name: "eth*" because 50-cloud-init.yaml also delivers a match here and I believe that results in a collision on eth0 with the original match keys on macaddress. So cloud-init's eth0 netplan yaml, would still not match for a reattached eth0 if the macaddress changed.
I'm testing now on azure whether we can emit something like:
network:
....version: 2
....ethernets:
........ephemeral:
............dhcp4: true
............match:
................driver: hv_netvsc
................name: "!eth0"
............optional: true


Which hopefully will avoid potential conflicts with 50-cloud-init.yaml for eth0.
Cloud-init will have to sort the detatch/re-attach story for eth0 as a later time I expect.

If the name !eth0 works, then we'll just emit that static file /etc/netplan/99-azure-hotplug.yaml and I'll drop the udev rules from this script on netplan-enabled systems.


3. Thanks for the suggestion on /run/netplan instead of /etc/netplan for ephemeral, will make those changes if the static /etc/netplan/99-azure-hotplug,yaml is not workable across non-eth0 nic add.

4. Much thanks on the 'netplan apply'behavior info. If we can emit a static /etc/netplan/99-azure-hotplug.yaml per suggestion 2, then we probably don't have to go this route. I only called netplan apply here due to the udev add firing, then new yaml written and netplan needing to refresh that content to react to it. Hopefully with your other suggestion and netplan matching regex we can avoid this.


-- 
https://code.launchpad.net/~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug/+merge/347212
Your team VMBuilder is requested to review the proposed merge of lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm.