← Back to team overview

vmbuilder team mailing list archive

Re: [Merge] lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm

 


Diff comments:

> === modified file 'templates/img-extra-nets.tmpl'
> --- templates/img-extra-nets.tmpl	2017-08-22 19:29:36 +0000
> +++ templates/img-extra-nets.tmpl	2018-06-01 02:30:12 +0000
> @@ -5,6 +5,7 @@
>  # vi: ts=4 noexpandtab syntax=sh
>  
>  int_d="/run/network/interfaces.ephemeral.d"
> +netplan_d="/etc/netplan"

We were only going to use /run if we wanted an ephemeral configuration setup per-udev device add, because we wouldn't then worry about it hanging around after reboot. But, since we are pre-loading a single static netplan yaml file, I think it's best to avoid udev scripts altogether and just leave around a flexible single static file. It also keeps the cloud-image environment simpler to avoid trying to load stuff into /run on each boot.

>  
>  function config_upstart {
>      # Give an upstart job for defining a secondary interface


-- 
https://code.launchpad.net/~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug/+merge/347212
Your team VMBuilder is requested to review the proposed merge of lp:~chad.smith/vmbuilder/jenkins_kvm_azure_netplan_hotplug into lp:~ubuntu-on-ec2/vmbuilder/jenkins_kvm.


References