widelands-dev team mailing list archive

[SirVer <724344@xxxxxxxxxxxxxxxxxx>]

Okay, so I suggest we pressure on with build 16. I'd suggest we post the
security issue right away on the website as Jari suggested and also
mention that build 16 will contain the fix. Only joining trusted games
should not be a strong restriction.

-- 
You received this bug notification because you are a member of Widelands
Developers, which is a direct subscriber.
https://bugs.launchpad.net/bugs/724344

Title:
  Security issue in sending files in network game

Status in Widelands:
  Fix Committed

Bug description:
  Network games have capability to send savegames and maps over network.
  Receiving player first checks if the file exists, and if it exists,
  existing file is renamed before new file is received. Handling of the
  received file is not secure as FileSystem classes support using ".."
  in path to go out of filesystem root. For example sending a file name
  like "../.bashrc" allows some nasty things to happen.

  To fix this issue either FileSystem code should enforce that file
  accesses stay within created file system's root. Alternatively paths
  coming from network should be validated and  "..",  "~" and "/"
  accesses should be filtered out. Perhaps it's wise to implement both.