widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~nomeata/widelands/plot-improvements into lp:widelands

To: Joachim Breitner <nomeata@xxxxxxxxxx>
From: Nicolai Hähnle <prefect_@xxxxxxx>
Date: Thu, 10 Nov 2011 13:41:45 -0000
In-reply-to: <20111108224923.31362.84921.launchpad@ackee.canonical.com>
Reply-to: mp+81649@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

A bit late since this has already been merged, however there's a minor nitpick:

DiscreteSlider::set_labels should take its argument as a reference, i.e. as a const std::vector<std::string> &. That would avoid one unnecessary copying operation of the label vector.
-- 
https://code.launchpad.net/~nomeata/widelands/plot-improvements/+merge/81649
Your team Widelands Developers is requested to review the proposed merge of lp:~nomeata/widelands/plot-improvements into lp:widelands.

References

[Merge] lp:~nomeata/widelands/plot-improvements into lp:widelands
From: Joachim Breitner, 2011-11-08