widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #00500
Re: [Merge] lp:~tino79/widelands/gettext018 into lp:widelands
First this affects gettext-18 on windows and mac. The source code implies that libintl tries to do something smart with locale on win and mac. So why not stay with mac solution for gettext-18 (LIBINTL_VERSION >= 0x001201), which just uses libintl_setlocale instead of std::locale. Actually it would be equally good there to just use normal setlocale, as preprocessor will change it to libintl_setlocale anyway.
By the way, does anyone know the reason for using std::setlocale instead of setlocale? It would work without extra ifdefs.
--
https://code.launchpad.net/~tino79/widelands/gettext018/+merge/83220
Your team Widelands Developers is requested to review the proposed merge of lp:~tino79/widelands/gettext018 into lp:widelands.
References