widelands-dev team mailing list archive

["Jens Beyer \(Qcumber-some\)" <Qcumber-some@xxxxxxxxxxxxx>]

Jens Beyer (Qcumber-some) has proposed merging lp:~qcumber-some/widelands/alocritani-896879-switch_buttons into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #896879 in widelands: "Patch - Changes to spinboxes' behaviour"
  https://bugs.launchpad.net/widelands/+bug/896879

For more details, see:
https://code.launchpad.net/~qcumber-some/widelands/alocritani-896879-switch_buttons/+merge/83532

On behalf of alocritani (see bug comments).
-- 
https://code.launchpad.net/~qcumber-some/widelands/alocritani-896879-switch_buttons/+merge/83532
Your team Widelands Developers is requested to review the proposed merge of lp:~qcumber-some/widelands/alocritani-896879-switch_buttons into lp:widelands.

=== modified file 'src/ui_basic/spinbox.cc'
--- src/ui_basic/spinbox.cc	2011-11-23 17:05:46 +0000
+++ src/ui_basic/spinbox.cc	2011-11-27 21:31:25 +0000
@@ -110,7 +110,7 @@
 	sbi->butPlus =
 		new Button
 			(this, "+",
-			 butw * 21 / 10, 0, butw, butw,
+			 w - butw * 31 / 10, 0, butw, butw,			 
 			 sbi->background,
 			 "+", _("Increase the value"),
 			 true, false);
@@ -118,7 +118,7 @@
 	sbi->butMinus =
 		new Button
 			(this, "-",
-			 w - butw * 31 / 10, 0, butw, butw,
+			 butw * 21 / 10, 0, butw, butw,
 			 sbi->background,
 			 "-", _("Decrease the value"),
 			 true, false);
@@ -129,7 +129,7 @@
 		sbi->butTenPlus =
 			new Button
 				(this, "++",
-				 0, 0, butw * 2, butw,
+				 w - 2 * butw, 0, butw * 2, butw,
 				 sbi->background,
 				 "++", _("Increase the value by 10"),
 				 true, false);
@@ -137,7 +137,7 @@
 		sbi->butTenMinus =
 			new Button
 				(this, "--",
-				 w - 2 * butw, 0, butw * 2, butw,
+				 0, 0, butw * 2, butw,
 				 sbi->background,
 				 "--", _("Decrease the value by 10"),
 				 true, false);