← Back to team overview

widelands-dev team mailing list archive

[Bug 916545] Re: About depending on GGZ packages

 

alright I will change the strings to static const std::string
IGPCMD_LOGIN = "LOGIN"; etc.

about the testsuite:
unfortunally the InternetGaming class is not *that* much "standalone" - it at least needs the network code for sending and receiving data packages + it has to be a chat controller (we could move all the chat stuff to the internet_lobby code, but that would only complicate things, as normally this is, what the InternetGaming class should handle). I don't know how much dependencies the chat controller and the network code has though... maybe it isn't that much and we could compile it as library quite easily (???)
I am still in the process of refactoring, so perhaps I will see things different in a few days ;) ...

anyways do you think the test suite should be written "in writing
process" or only after the first completely working implementation? To
be honest: I never wrote a testsuite before and all time I spend at the
moment in the internet code is at the border of "too much time" ;) ...
reading into the testsuit writing documentation would surely take a lot
of that time... so i would prefare to get it working and once it is
working to add a testsuit to ensure all changes that anyone does
afterwards does not break anything.

-- 
You received this bug notification because you are a member of Widelands
Developers, which is a bug assignee.
https://bugs.launchpad.net/bugs/916545

Title:
  About depending on GGZ packages

Status in Widelands:
  Confirmed
Status in “widelands” package in Debian:
  New

Bug description:
  I noticed a bug report in Debian which basically suggests to drop the
  GGZ packages because it is unmaintained upstreams. Since Widelands
  depends on ggz, this of course affects us there (not to mention Debian
  derivaties like Ubuntu and Linux Mint).

  I know the ggz dependency has been discussed a bit before, but we
  should probably figure out what the long-term plan is.

To manage notifications about this bug go to:
https://bugs.launchpad.net/widelands/+bug/916545/+subscriptions