widelands-dev team mailing list archive

[Angelo Locritani <angelo.locritani@xxxxxxxxx>]

Angelo Locritani has proposed merging lp:~alocritani/widelands/bugfix-924768 into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #924768 in widelands: "Rework barbarian barrier's statistics"
  https://bugs.launchpad.net/widelands/+bug/924768

For more details, see:
https://code.launchpad.net/~alocritani/widelands/bugfix-924768/+merge/91544

Lowered capacity of barbarians' donjon.

Checked maps and campaigns: there is not a single case where more than 4 soldiers are in a donjon.

Regarding existing savegame: donjons keep only 4 soldiers, but no change recorded in statistics (ie: 45 total soldiers before changing and 45 after changing) - so statistics are definitely wrong. Also, numbers displayed on top of donjons still report 5 soldiers until something force them to refresh (attack, reduce capacity, remove soldier, etc...). Not sure if this can be avoided (maybe forcing a refresh on game load?).

I fear 1 soldier is lost for every donjon that used to keep 5, but I have no idea how to check it (statistics are wrong - maybe manually counting?)

If you think it is a big problem, feel free to reject the change or to suggest me a possible workaround.
-- 
https://code.launchpad.net/~alocritani/widelands/bugfix-924768/+merge/91544
Your team Widelands Developers is requested to review the proposed merge of lp:~alocritani/widelands/bugfix-924768 into lp:widelands.

=== modified file 'tribes/barbarians/donjon/conf'
--- tribes/barbarians/donjon/conf	2011-10-03 15:51:56 +0000
+++ tribes/barbarians/donjon/conf	2012-02-04 10:29:21 +0000
@@ -1,5 +1,5 @@
 size=medium
-max_soldiers=5
+max_soldiers=4
 heal_per_second=2
 conquers=8
 vision_range=17