widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/assert into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #986611 in widelands: "Issues reported by cppcheck"
  https://bugs.launchpad.net/widelands/+bug/986611

For more details, see:
https://code.launchpad.net/~hjd/widelands/assert/+merge/103340

Another tiny fix from the cppcheck report. 
-- 
https://code.launchpad.net/~hjd/widelands/assert/+merge/103340
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/assert into lp:widelands.

=== modified file 'src/logic/message_queue.h'
--- src/logic/message_queue.h	2012-02-15 21:25:34 +0000
+++ src/logic/message_queue.h	2012-04-24 18:10:44 +0000
@@ -101,8 +101,8 @@
 		insert
 			(std::map<Message_Id, Message *>::end(),
 			 std::pair<Message_Id, Message *>(++m_current_message_id, &message));
+		assert_counts();
 		return m_current_message_id;
-		assert_counts();
 	}
 
 	/// Sets the status of the message with the given id, if it exists.