widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~peter.waller/widelands/eliminate-unused-arguments into lp:widelands

To: Peter Waller <peter.waller@xxxxxxxxx>
From: SirVer <SirVer@xxxxxx>
Date: Sat, 09 Jun 2012 11:49:20 -0000
In-reply-to: <20120608223924.9368.58673.launchpad@ackee.canonical.com>
Reply-to: mp+109448@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Nice Work Peter! I saw that you also improved the flexibility of the CodeChecker quite a bit. That is really good work.

I am not a fan of the commenting of the parameters. Can you tell me why you find this superior to straightup deleting them? 
-- 
https://code.launchpad.net/~peter.waller/widelands/eliminate-unused-arguments/+merge/109448
Your team Widelands Developers is requested to review the proposed merge of lp:~peter.waller/widelands/eliminate-unused-arguments into lp:widelands.

References

[Merge] lp:~peter.waller/widelands/eliminate-unused-arguments into lp:widelands
From: Peter Waller, 2012-06-08