widelands-dev team mailing list archive

[Nasenbaer <Nasenbaer@xxxxxxxxxxxx>]

well it is not equal because:
* take the case where coal is needed, but at least the economy needs smoked_fish (bread does not matter in that case)

return=skipped unless economy needs coal or not economy needs bread -> no skip because of coal
return=skipped unless not economy needs smoked_fish -> no skip because of coal

return=skipped unless economy needs coal or not economy needs bread -> no skip because of coal
return=skipped unless not economy needs smoked_fish -> skipped because smoked_fish is needed

the only real equivalent would be:

return=skipped unless economy needs coal or not economy needs bread or not economy needs smoked_fish

but I do not know if that is accepted by the Widelands skip logic - if yes, that would be a real alternative because it would reduce the number of checks maximally :)
-- 
https://code.launchpad.net/~widelands-dev/widelands/bug988870/+merge/174639
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug988870 into lp:widelands.