widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #01398
Re: [Merge] lp:~widelands-dev/widelands/game_end_summary into lp:widelands
Review: Needs Fixing
Some more comments here. I also changed some style and nits around. Also you forgot to check in logic/playersmanager.[h|cc]. I also think the file should be called players_manager.h and the class PlayersManager (though we are not very consistent about this either - we definitely should do a bunch of style cleanups throughout the code base).
--
https://code.launchpad.net/~widelands-dev/widelands/game_end_summary/+merge/176000
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/game_end_summary.
References