widelands-dev team mailing list archive
-
widelands-dev team
-
Mailing list archive
-
Message #01454
Re: [Merge] lp:~widelands-dev/widelands/bug1206563 into lp:widelands
very wonderful.
I think this would not have needed a review :). Feel free to commit things like this directly into trunk - but always make sure that you are merging into trunk and push this (never merge trunk into your working branch and push this, as this changes history and ends in a huge mail bomb).
I think code reviews are very useful for all involved - they should not be a burden though, but always help. So do not think of them as a necessary, but use them to your advantage. I personally send everything that is > 10 lines (roughly) for review.
--
https://code.launchpad.net/~widelands-dev/widelands/bug1206563/+merge/177721
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug1206563 into lp:widelands.
References