widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/lua_mapview_persistence into lp:widelands

To: cghislai <charlyghislain@xxxxxxxxx>
From: SirVer <SirVer@xxxxxx>
Date: Thu, 01 Aug 2013 03:05:36 -0000
In-reply-to: <20130727111425.5777.22634.launchpad@ackee.canonical.com>
Reply-to: mp+177251@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

I think this is the very right approach to doing this. I am still in the USA right now, and pretty loaded, so I am still slow to review code. However one thing immediately: game_mapview_player_data_paquet should be game_mapview_player_data_packet. Same for the classes. Why did you change this to Paquet?
-- 
https://code.launchpad.net/~widelands-dev/widelands/lua_mapview_persistence/+merge/177251
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua_mapview_persistence.

References

[Merge] lp:~widelands-dev/widelands/lua_mapview_persistence into lp:widelands
From: cghislai, 2013-07-27