widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/message_expired into lp:widelands

To: cghislai <charlyghislain@xxxxxxxxx>
From: SirVer <SirVer@xxxxxx>
Date: Wed, 07 Aug 2013 00:49:27 -0000
In-reply-to: <20130806200623.2615.29885.launchpad@ackee.canonical.com>
Reply-to: mp+178836@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

keep_when_removed is a bad name choice. how about calling it link_lifetime_to_msgsender. It would then be the inverse of what it is now, but easier to understand. Please change the name to something different and then merge it to trunk yourself?

Approved, but please fix this one issue.
-- 
https://code.launchpad.net/~widelands-dev/widelands/message_expired/+merge/178836
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/message_expired.

References

[Merge] lp:~widelands-dev/widelands/message_expired into lp:widelands
From: cghislai, 2013-08-06