widelands-dev team mailing list archive

[Hans Joachim Desserud <launchpad@xxxxxxxxxxxx>]

Hans Joachim Desserud has proposed merging lp:~hjd/widelands/unused-variable into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)

For more details, see:
https://code.launchpad.net/~hjd/widelands/unused-variable/+merge/180685

Removed an unused variable, since the assigned value was never read. 
-- 
https://code.launchpad.net/~hjd/widelands/unused-variable/+merge/180685
Your team Widelands Developers is requested to review the proposed merge of lp:~hjd/widelands/unused-variable into lp:widelands.

=== modified file 'src/logic/player.cc'
--- src/logic/player.cc	2013-08-13 20:25:06 +0000
+++ src/logic/player.cc	2013-08-17 08:47:24 +0000
@@ -114,12 +114,11 @@
 {
 	assert(former_buildings && former_buildings->empty());
 	former_buildings->push_back(bi);
-	bool done = false;
-	while (not done) {
+
+	while (true) {
 		Widelands::Building_Index oldest_idx = former_buildings->front();
 		const Widelands::Building_Descr * oldest = tribe_descr.get_building_descr(oldest_idx);
 		if (!oldest->is_enhanced()) {
-			done = true;
 			break;
 		}
 		for