widelands-dev team mailing list archive

[Tino <tino.miegel@xxxxxxxxxxxxxx>]

Tino has proposed merging lp:~widelands-dev/widelands/fix_bug_1271080 into lp:widelands.

Requested reviews:
  Widelands Developers (widelands-dev)
Related bugs:
  Bug #1271080 in widelands: "Deletion of replay files on win32"
  https://bugs.launchpad.net/widelands/+bug/1271080

For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fix_bug_1271080/+merge/202412

MinGW has a bug http://sourceforge.net/p/mingw/bugs/2152/
This leads to a faulty time calculation and widelands deletes the replay files when it shouldn't.

Steps to reproduce:
- Set "Remove replays after 1 day"
- Start a game to let widelands write a replay
- restart widelands

=> Result: On restart widelands deletes the replay from the current day
-- 
https://code.launchpad.net/~widelands-dev/widelands/fix_bug_1271080/+merge/202412
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/fix_bug_1271080 into lp:widelands.

=== modified file 'src/wlapplication.h'
--- src/wlapplication.h	2013-10-29 07:51:14 +0000
+++ src/wlapplication.h	2014-01-21 08:48:15 +0000
@@ -19,6 +19,11 @@
 
 #ifndef WLAPPLICATION_H
 #define WLAPPLICATION_H
+
+//Workaround for bug http://sourceforge.net/p/mingw/bugs/2152/
+#ifdef __MINGW32__
+#define _USE_32BIT_TIME_T 1
+#endif
 
 #include <cstring>
 #include <map>