← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/i18n into lp:widelands

 

After I could compile and test, this is the stuff that still needs looking into:

===============================

/test/maps/expedition.wmf/scripting/init.lua
- upper or lowercase needed here?
  wait_for_message("Expedition Ready")
  wait_for_message("Port Space Found")

===============================

/utils/test/test_lua-xgettext.py

- 2 differences, please check:

def run_test(self):
self.p.parse(self.code, self.filename)

+ print self.p.findings - do we need this line? It's in gci18nfixes, but missing from i18n

and at EOF:

- # k = SomeTestClass()
- # unittest.TextTestRunner().run(k)
+ k = SomeTestClass()
+ unittest.TextTestRunner().run(k)

===============================

Help messages in nethost.cc
-- 
https://code.launchpad.net/~widelands-dev/widelands/i18n/+merge/209212
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/i18n into lp:widelands.


References