widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/handle_tab into lp:widelands

To: mp+209406@xxxxxxxxxxxxxxxxxx
From: Shevonar <infomh@xxxxxxxxxxx>
Date: Wed, 05 Mar 2014 10:11:02 -0000
In-reply-to: <20140305092921.21289.27050.launchpad@ackee.canonical.com>
Reply-to: mp+209406@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Needs Fixing

I just noticed a little misinterpretation: case SDLK_KP_ENTER is actually not an empty switch case. It just falls through to case SDLK_RETURN to handle the Enter key on the keypad the same way as the Return key. A case is only redundant if it falls through to the default case. Even a case foo: break; might be useful as it prevents the default case from execution.
-- 
https://code.launchpad.net/~widelands-dev/widelands/handle_tab/+merge/209406
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/handle_tab.

References

[Merge] lp:~widelands-dev/widelands/handle_tab into lp:widelands
From: Tino, 2014-03-05