← Back to team overview

widelands-dev team mailing list archive

Re: [Merge] lp:~widelands-dev/widelands/moved-classes into lp:widelands

 

I support this refactoring task and raise my pint for you!!

- While you do the refactorings, could you get rid of the abbreviations too, please
e.g. sp_gamecontroller.[cc|h] -> single_player_game_controller.[cc|h].
- Add 'override' to derived classes.
- Extra points if you move method definitions out of .h files into the .cc file (also one liners until proven that the inlining is actually beneficial) and documentation from the .cc file into the .h file. 

-- 
https://code.launchpad.net/~widelands-dev/widelands/moved-classes/+merge/212302
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/moved-classes into lp:widelands.


References