← Back to team overview

widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/scriptconsole into lp:widelands

To: mp+214439@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Sun, 06 Apr 2014 16:05:50 -0000
In-reply-to: <20140406142923.5012.74264.launchpad@ackee.canonical.com>
Reply-to: mp+214439@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

Just a minor nit:
- Move the factory methods at the top of the class and document them.

Otherwise LGTM. 
-- 
https://code.launchpad.net/~widelands-dev/widelands/scriptconsole/+merge/214439
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/scriptconsole.

References

[Merge] lp:~widelands-dev/widelands/scriptconsole into lp:widelands
From: Tino, 2014-04-06