widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~widelands-dev/widelands/bug-1298309 into lp:widelands

To: mp+215707@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Mon, 14 Apr 2014 17:35:13 -0000
In-reply-to: <20140414172528.7350.53574.launchpad@ackee.canonical.com>
Reply-to: mp+215707@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

lgtm. just a nit:

+      rt("image=tribes/atlanteans/".. f.immovable.name .."/menu.png",
Add a todo here that this should representative_image as soon as we wrap it. Relying on menu.png being there is fragile, especially since there was already talk to remove menu.png pictures as they are not used in many places anymore.

-- 
https://code.launchpad.net/~widelands-dev/widelands/bug-1298309/+merge/215707
Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1298309 into lp:widelands.

References

[Merge] lp:~widelands-dev/widelands/bug-1298309 into lp:widelands
From: GunChleoc, 2014-04-14