widelands-dev team mailing list archive

Thread
Date

Re: [Merge] lp:~hjd/widelands/disabled-s390-patch into lp:~widelands-dev/widelands/debian

To: mp+217293@xxxxxxxxxxxxxxxxxx
From: SirVer <SirVer@xxxxxx>
Date: Sat, 26 Apr 2014 09:54:45 -0000
In-reply-to: <20140425201920.28481.78318.launchpad@ackee.canonical.com>
Reply-to: mp+217293@xxxxxxxxxxxxxxxxxx
Sender: bounces@xxxxxxxxxxxxx

Review: Approve

I looked through this and I wondered why you did not also delete the patch file. Unused files in a repository are usually a bad idea, since they are forgotten over time. If somebody needs it back in the future, they can reverse-cherrypick your commit.

Otherwise lgtm.
-- 
https://code.launchpad.net/~hjd/widelands/disabled-s390-patch/+merge/217293
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/debian.

References

[Merge] lp:~hjd/widelands/disabled-s390-patch into lp:~widelands-dev/widelands/debian
From: Hans Joachim Desserud, 2014-04-25