widelands-dev team mailing list archive

[Shevonar <infomh@xxxxxxxxxxx>]

I changed some formatting issues and small obvious errors. I also changed documentation to doxygen comment style so it gets picked up.

Here are the remaining questions:
- Why did you hard code the compiler in compile.sh
- Why are critter sound_effect split in directory and name and not just a path to the sound file?
- widelands_streamread.h.THIS should be just .h but is not used anyways. Remove?
- '// TODO "stone" is defined as "granit" in the world': Can this be fixed easily? Seems to fit in the context of this commit.
- ResourceDescription::get_editor_pic looks very wired. I am not totally sure what this method does but I am almost sure that there is an easier way with less complexity to achieve the same result. However, you did not write this code.
- TerrainTypeFromString is just a helper method. I don't know how this is usually handled in C++ but I would have maybe used a private class method (I am more of a Java developer).
- Uint32 in src/sound/fxset.h: What is the difference between Uint32 and uint32_t? Should it be changed?
-- 
https://code.launchpad.net/~widelands-dev/widelands/one_world/+merge/222708
Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/one_world.